Skip to content

fix: resolve UI issues with checkbox state and popover visibility #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

fix: resolve UI issues with checkbox state and popover visibility #5387

merged 2 commits into from
Jul 4, 2025

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jul 3, 2025 •
edited by ellipsis-dev bot
Loading

Description

Fixes two UI issues:

  1. ExperimentalSettings checkbox stuck in checked state
  2. CodeIndexPopover appearing above settings view

Changes

  • Fixed checkbox state management by correctly using vscode.postMessage for backend updates
  • Fixed popover z-index issue by using ChatView's portal container (same as ModeSelector)
  • Added event listener to close popover on tab switches

Testing

  • All tests pass (467 passed, 1 skipped)
  • Manually verified checkbox can be toggled
  • Manually verified popover stays behind settings view

Important

Fixes checkbox state and popover visibility issues in UI components by updating state management and z-index handling.

  • UI Fixes:
    • Fixed checkbox state in ExperimentalSettings.tsx by updating state management logic.
    • Fixed popover visibility in CodeIndexPopover.tsx by using useRooPortal for z-index management.
    • Added event listener in SettingsView.tsx to close popover on tab switches.
  • Testing:
    • All tests pass (467 passed, 1 skipped).
    • Manually verified checkbox toggling and popover visibility.

This description was created by Ellipsis for d2e47ee. You can customize this summary. It will automatically update as commits are pushed.

@daniel-lxs
fix: resolve UI issues with checkbox state and popover visibility
b62f29b 
- Fix ExperimentalSettings checkbox stuck in checked state by correctly updating backend state
- Fix CodeIndexPopover appearing above settings view by using ChatView portal container
- Add event listener to close popover on tab switches
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners July 3, 2025 23:40
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused labels Jul 3, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jul 3, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 3, 2025 •
edited
Loading

✅ No security or compliance issues detected. Reviewed everything up to d2e47ee.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes
Change Type Relevant files
Refactor ► CodeIndexPopover.tsx
    Add portal container for popover
► ExperimentalSettings.tsx
    Update codebase index state handling
► SettingsView.tsx
    Refactor codebase index configuration handling

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 4, 2025
@mrubens mrubens merged commit f96021f into main Jul 4, 2025
18 of 19 checks passed
@mrubens mrubens deleted the fix/ui-popover-checkbox-issues branch July 4, 2025 02:01
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 4, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens mrubens approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:S This PR changes 10-29 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daniel-lxs @mrubens @hannesrudolph